Update toolchain nightly-2026-03-14 by LegNeato · Pull Request #545 · Rust-GPU/rust-gpu

LegNeato · 2026-03-07T00:03:26Z

Requires #542

LegNeato · 2026-03-07T00:06:20Z

crates/rustc_codegen_spirv/src/builder/intrinsics.rs

+        _args: &[OperandRef<'tcx, Self::Value>],
+        _is_cleanup: bool,
+    ) -> Self::Value {
+        bug!("LLVM intrinsic call not supported in SPIR-V backend: {instance:?}")


I think we want to use this rather than our own home-grown replacements, but didn't want to do it in this PR.

nazar-pc · 2026-03-07T14:27:06Z

cargo-gpu will need to be updated again to match this, custom target specs since recently require an unstable CLI option:

error: `.json` target specs require -Zjson-target-spec

nazar-pc · 2026-03-08T07:29:47Z

Tried to update with a patched cargo-gpu locally and it worked, but generated these warnings that were not present before:

Details

warning: failed to find and remove `format_args!` construction for this `panic!`
    --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mod.rs:2086:9
     |
2086 | /         ub_checks::assert_unsafe_precondition!(
2087 | |             check_language_ub,
2088 | |             "ptr::read_volatile requires that the pointer argument is aligned",
...    |
2092 | |             ) => ub_checks::maybe_is_aligned(addr, align)
2093 | |         );
     | |_________^
     |
     = note: compilation may later fail due to leftover `format_args!` internals
     = note: [RUST-GPU BUG] bailed from panic entry-point call args

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mod.rs:531:5
    |
531 | /     ub_checks::assert_unsafe_precondition!(
532 | |         check_language_ub,
533 | |         "ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null \
534 | |         and the specified memory ranges do not overlap",
...   |
547 | |     );
    | |_____^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from panic entry-point call args

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59851, 1387, [3516, 3517])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59882, 1390, [3522, 3523])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:260:9
    |
260 | /         assert_unsafe_precondition!(
261 | |             check_library_ub,
262 | |             "slice::get_unchecked_mut requires that the index is within the slice",
263 | |             (this: usize = self, len: usize = slice.len()) => this < len
264 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59911, 1381, [3527, 3528])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59936, 1393, [3533, 3534])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59967, 1396, [3539, 3540])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(59998, 1399, [3545, 3546])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:260:9
    |
260 | /         assert_unsafe_precondition!(
261 | |             check_library_ub,
262 | |             "slice::get_unchecked_mut requires that the index is within the slice",
263 | |             (this: usize = self, len: usize = slice.len()) => this < len
264 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(60027, 1384, [3550, 3551])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:240:9
    |
240 | /         assert_unsafe_precondition!(
241 | |             check_language_ub, // okay because of the `assume` below
242 | |             "slice::get_unchecked requires that the index is within the slice",
243 | |             (this: usize = self, len: usize = slice.len()) => this < len
244 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(60052, 1402, [3556, 3557])])

warning: failed to find and remove `format_args!` construction for this `panic!`
   --> /home/nazar-pc/.rustup/toolchains/nightly-2026-03-06-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs:326:9
    |
326 | /         assert_unsafe_precondition!(
327 | |             check_library_ub,
328 | |             "slice::get_unchecked_mut requires that the index is within the slice",
329 | |             (end: usize = self.end(), len: usize = slice.len()) => end <= len
330 | |         );
    | |_________^
    |
    = note: compilation may later fail due to leftover `format_args!` internals
    = note: [RUST-GPU BUG] bailed from fmt::Arguments::new call sequence ([Call(60985, 1071, [60970]), Call(60988, 1378, [3948, 3949])])

LegNeato · 2026-03-08T08:11:48Z

Cool, I'll take a look. There were some changes in this area.

crates/rustc_codegen_spirv/src/builder/builder_methods.rs

fee1-dead · 2026-03-09T23:55:37Z

crates/rustc_codegen_spirv/src/builder/format_args_decompiler.rs

I wonder whether this is still needed? After #148789, we can simply detect Arguments::from_str if the argument is a const str.

panic and panic_nounwind use Arguments::from_str. But panic_display / unreachable_display still go through format_args and panic_bounds_check also formats dynamic values. So I think we need both.

crates/rustc_codegen_spirv/src/builder/intrinsics.rs

LegNeato · 2026-03-11T21:22:43Z

@nazar-pc I think what you saw should be fixed.

nazar-pc · 2026-03-11T21:42:01Z

Yes, clippy is happy now, tests are passing too

crates/rustc_codegen_spirv/src/codegen_cx/constant.rs

fee1-dead · 2026-03-13T03:20:05Z

crates/rustc_codegen_spirv/src/codegen_cx/constant.rs

+                        let alloc_size = alloc.inner().size();
+                        if alloc_size.bytes() % elem_size.bytes() != 0 {
+                            return None;
+                        }


This would be an error right? Would it make sense to silently do nothing here?

Good question. The trailing bytes can't form a complete element and are can't be accessed through the array, so truncating to floor(alloc_size / elem_size) should be fine? Should I change it? I'm not sure about edge-cases as this isn't my wheelhouse and AI did a lot of these changes.

crates/rustc_codegen_spirv/src/codegen_cx/declare.rs

crates/rustc_codegen_spirv/src/abi.rs

crates/rustc_codegen_spirv/src/builder_spirv.rs

crates/rustc_codegen_spirv/src/lib.rs

crates/rustc_codegen_spirv/build.rs

Update the pinned workspace toolchain to rustc 1.96.0-nightly (1d8897a4e 2026-03-13) and keep REQUIRED_RUST_TOOLCHAIN in sync. Mirror the current rustc_codegen_ssa crate-attribute header in lib.rs, keep rustc_codegen_spirv-specific lint allowances outside that mirrored block, and drop the now-unneeded bootstrap-only header filtering from build.rs.

Use exact rust_gpu attribute paths with get_attrs_by_path, let AggregatedSpirvAttributes parse filtered iterators directly, and replace the manual debug filename arena allocation with DroplessArena::alloc_str. Also port the rustc-private API drift in this nightly by importing assert_matches from std, using rustc_span::Spanned directly, and renaming BackendRepr::ScalableVector to SimdScalableVector.

Keep the existing runtime-array reification path for const pointer bitcasts, but report a specific zombie reason when the backing allocation size is not a multiple of the runtime-array element size instead of silently falling through to the generic const_bitcast error.

This disassembly test only cares about the rotate lowering pattern, not source line tables. Strip OpLine records entirely so line-number drift across toolchains does not require reblessing the test.

fee1-dead · 2026-03-14T19:02:56Z

cc @Firestar99 for some testing

LegNeato commented Mar 7, 2026

View reviewed changes

LegNeato force-pushed the pr-542-latest-nightly-refresh branch from 14cdf92 to 6434ab8 Compare March 7, 2026 00:22

nazar-pc mentioned this pull request Mar 8, 2026

Unclear ICE #312

Open

fee1-dead requested changes Mar 9, 2026

View reviewed changes

LegNeato added 23 commits March 10, 2026 17:47

Update pinned toolchain to nightly-2026-03-06

aa9ef5e

Port backend trait surface to rustc 1.96 APIs

2de9db3

Port backend internals and ABI plumbing to latest nightly

285545f

Handle newer panic format_args lowering patterns

be7148b

Handle nightly panic format_args lowering and unsized const reification

771aa99

Fix new nightly clippy suggestions in type trie and linker

0453c80

Port linker test harness to current rustc session APIs

543eb26

Resolve new collapsible-match clippy lints in example runners

a303ad3

Guard runtime-array const reification against truncation and ZST tails

c70cdc3

Replace fmt::Arguments sentinel metadata with typed constructor tags

a8b858a

Gate bounds/precondition panic-entry detection to non-local core symbols

2af3b54

Fix panic-entry matching and disable-pqp unused-features lint

1c64a85

Bless compiletest stderr for updated nightly diagnostics

6c9a7b4

Rustfmt codegen_cx panic-entry matcher formatting

e0ef82c

spirv-builder: pass -Zjson-target-spec for JSON targets

d5b1aef

compiletests: bless sampled image query_size_lod stderr

65058a9

codegen: adapt panic format_args decompiler for new nightly shapes

5795f08

codegen: stop treating core precondition_check as panic entry point

3ae3af3

codegen: harden panic format_args fallback for split/pass-through shapes

7669aa1

codegen: preserve raw fn ABI query invariants

899a7b0

codegen: harden panic message decoding for nightly call shapes

156887d

codegen: preserve panic_const messages in panic fast path

facad7d

codegen: decode panic_bounds_check debug-printf args

b4a6a4c

LegNeato added 9 commits March 10, 2026 17:47

compiletests: normalize relative spirv-std paths in stderr

e900eb2

fix lint and spv1.3 stderr for panic/message updates

c3cedf9

codegen: use size-based alloca for panic arg spill

12cc6a9

codegen: emit typed local panic spills without typed_alloca

12c5bb4

codegen: align funclet stubs and likely handling notes

f9d718f

codegen: fix panic entry-point classification and arg decoding

203c750

codegen: match likely/unlikely via intrinsic symbols

2f54cdf

compiletests: update ptr_copy stderr for extra pointer-cast diagnostic

ee49a27

style: run cargo fmt --all

db063f6

LegNeato force-pushed the pr-542-latest-nightly-refresh branch from 2fe48e0 to db063f6 Compare March 11, 2026 00:50

LegNeato marked this pull request as ready for review March 11, 2026 18:15

LegNeato requested review from Firestar99 and eddyb as code owners March 11, 2026 18:15

LegNeato requested a review from fee1-dead March 12, 2026 06:35

fee1-dead requested changes Mar 13, 2026

View reviewed changes

LegNeato added 4 commits March 13, 2026 21:48

compiletests: normalize issue-1062 OpLine output

51193ef

This disassembly test only cares about the rotate lowering pattern, not source line tables. Strip OpLine records entirely so line-number drift across toolchains does not require reblessing the test.

LegNeato changed the title ~~Update toolchain 2026-03-06~~ Update toolchain nightly-2026-03-14 Mar 14, 2026

Conversation

LegNeato commented Mar 7, 2026

Requires #542

Uh oh!

LegNeato Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

nazar-pc commented Mar 7, 2026

Uh oh!

nazar-pc commented Mar 8, 2026

Uh oh!

LegNeato commented Mar 8, 2026

Uh oh!

Uh oh!

fee1-dead Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

LegNeato Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LegNeato commented Mar 11, 2026

Uh oh!

nazar-pc commented Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

fee1-dead Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

LegNeato Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fee1-dead commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants